search

Hypertopic / HyperGlosae

A Nelsonian hypertext infrastructure for digital humanities
11 stars 21 forks source link

153 - Upload a picture into a document #184

Closed raphaelweis closed 5 months ago

raphaelweis commented 6 months ago

We, Raphaël WEIS, Fabien PETIT, Barnabé PETIT, Louis DUHALBERRUER, Martin GANDON, hereby grant to Hyperglosae maintainers the right to publish our contribution under the terms of any licenses the Free Software Foundation classifies as Free Software Licenses.

Closes #153.

raphaelweis commented 5 months ago

The implementation for uploading an image is working correctly, and the associated test passes correctly. I think some tests are broken following some css adjustments I had to make, I will work on fixing those on friday. Additionally, this branch hasn't been updated for 3 weeks, resulting in a merge conflict with main that will need to be addressed.

raphaelweis commented 5 months ago

Turns out I went too fast after refactoring my CSS file. I have added an import for my css file at the top of PassageMarginMenu and I've updated the CSS to use the class content instead of editable to prevent the changes from affecting the glose metadata layout.

Additionally, I've updated the branch with the latest commits on main, and I've changed the placeholder for the alt text of new images from the image name to <IMAGE DESCRIPTION>.

benel commented 5 months ago

Integrated as 597670f27dca514e9c4f5f4f5d4288c3e53e5a25 🎉

Well done @raphaelweis @nitram35 @petitfa1 @Barnabepetit!!!

Thank you for your contribution!