Closed GwenRiou closed 5 months ago
@KoffiBalayn @GwenRiou This seems to be a 2-weeks-old branch. Not the one you worked on last week.
I got back new-feature-156
and I'm currently working on it.
We finally did it! 🎉
@GwenRiou @KoffiBalayn
innerHTML
. A thread on StackOverflow advised to use mark.js
package that does add <mark>
element to the DOM without breaking it. I found react-mark.js
which is just a React wrapper for this library.mouseUp
, I have added a test to do nothing if the FormattedText
is editable (i.e. inside a EditableText
). @antooinex, @mbel-jordan @KoffiBalayn
I let you check the final version of the code, tests and scenarios.
That was a rough one! It is time to continue with easier features or fixes...
A regarder si c'est compatible avec les deux derniers merges sur le main. La sauvegare des documents ne fonctionnent plus En lien avec le fearture-156 qui permet de créer un commentaire à partir d'un text sur ligné. Le problème semble venir du ficher Editable text en particulier avec setEditedText et scholium et scholia.