Compatibility with Firefox version 10

Hypertopic / LaSuli

Social annotation for qualitative analysis

https://hypertopic.org/lasuli

GNU General Public License v3.0

12 stars 4 forks source link

Compatibility with Firefox version 10 #27

Closed benel closed 12 years ago

benel commented 12 years ago

As reported by @christophe-lejeune, version 10 of Firefox prevents LaSuli from creating an highlight. Argos logs show that the PUT method to the item was never sent.

Possibly related behaviors:

When doing the same thing in version 9, the password is asked while it is already defined in the config panel.
Note that PUT methods related to viewpoints are not affected.
Note also that there seems to be no effects of the presence of a secondary service in the config.

christophe-lejeune commented 12 years ago

One of my user reports that the following error message appears since LaSuli is installed in version 10 of Firefox. Error: TypeError: xulItems[item].getAttribute is not a function This message is featured each time Firefox is launched.

However other users does not report such a message. Thus, this message may or may not be related to this issue.

chao commented 12 years ago

This is not LaSuli error information. ;)

benel commented 12 years ago

I tried to rebuild LaSuli and to test it against automated validation tests.

There are no errors, but some warnings seem to indicate that the code could be restricted from doing what was intended. In particular:

An attempt was made to overwrite a global variable in some JavaScript code.
- lasuli.js:125
- jquery-ui-1.8.4.custom.min.js:539
- jquery.jqGrid.min.js: 406
It appears that an extension of a built-in JS type was made. This is not allowed for security and compatibility reasons.
- lasuli.js:120

benel commented 12 years ago

Ah. I finally found what changed in Firefox 10 for add-ons: http://blog.mozilla.com/addons/2011/12/01/compatibility-for-firefox-10/

Is there anything here that is used by LaSuli?

benel commented 12 years ago

isSameNode has been removed and it's used in:

content/js/capture.js
content/js/lasuli.ui.js

christophe-lejeune commented 12 years ago

The === operator is advised to be used instead to compare nodes.

benel commented 12 years ago

@christophe-lejeune, could you please confirm that your users don't have the problem anymore with this updated XPI so that I can close the issue?

christophe-lejeune commented 12 years ago

I have just asked my users. I will transmit their reports as soon as they are available.

benel commented 12 years ago

Fixed for the reporters.