Hypertopic / Porphyry

Corpus analyses confrontation
https://hypertopic.org/porphyry
GNU Affero General Public License v3.0
21 stars 165 forks source link

The building map should remain active when a topic is selected (see #591) #599

Closed Couapy closed 2 years ago

Couapy commented 2 years ago

Content

Please describe your contribution here...


Checklist

Please check that your pull request is correct:

Couapy commented 2 years ago

Tests fails, please see #560 status.

benel commented 2 years ago

I have added a scenario to help you identify the regression.

benel commented 2 years ago

Sorry, the scenario did not correspond to the exact case of the regression. Here is a new version of the scenario: https://github.com/Hypertopic/Porphyry/blob/v7/features/portfolio_browse.feature#L27-L36

benel commented 2 years ago

Please note that fix-560 is now merged (then you shouldn't include it in this PR anymore).

benel commented 2 years ago

I suspect that the problem is that you are getting the map from selected items (instead of corpora), while it is not there anymore once you have selected the topic. Did you check the scenario manually?