Not longer working with Valetudo 2021.01.1

[sylvaindd]

It doesn't seem to be working with the new Valetudo version 2021.01.1.

SyntaxError: Unexpected token e in JSON at position 0
    at JSON.parse (<anonymous>)
    at MqttClient.<anonymous> (/app/lib/MqttClient.js:86:42)
    at MqttClient.emit (events.js:315:20)
    at MqttClient._handlePublish (/app/node_modules/mqtt/lib/client.js:1277:12)
    at MqttClient._handlePacket (/app/node_modules/mqtt/lib/client.js:410:12)
    at work (/app/node_modules/mqtt/lib/client.js:321:12)
    at Writable.writable._write (/app/node_modules/mqtt/lib/client.js:335:5)
    at doWrite (/app/node_modules/mqtt/node_modules/readable-stream/lib/_stream_writable.js:409:139)
    at writeOrBuffer (/app/node_modules/mqtt/node_modules/readable-stream/lib/_stream_writable.js:398:5)
    at Writable.write (/app/node_modules/mqtt/node_modules/readable-stream/lib/_stream_writable.js:307:11)

Unfortunatly I removed my old topic, but I guess the map_data was previously in JSON as it tries to parse it as JSON.

[Hypfer]

Yep the map data is deflated and base64 encoded (optional) now and needs to be inflated first

[sylvaindd]

I made it work without base64 encoding.

zlib.inflate(message, (err, result) => {
  if(!err) {
    this.updateMapTopic(JSON.parse(result));
  } else {
    console.error(err);
  }
});

Tried this for base64 encoded, but didn't work :

zlib.inflate(Buffer.from(message, 'base64'), (err, result) => {
    if(!err) {
        this.updateMapTopic(JSON.parse(result));
    } else {
        console.error(err);
    }
});

Error: incorrect header check
    at Zlib.zlibOnError [as onerror] (zlib.js:182:17) {
  errno: -3,
  code: 'Z_DATA_ERROR'
}

[deku-m]

Having same issue with getting the map into home assistant Is there a workaround available in home assistant?

[leonardpitzu]

same for me

[leonardpitzu]

I sort of patched it but CPU and RAM usage are really high (about 25% CPU and 600MB RAM on a Synology 718+ NAS)...

[Zaschii]

any news/solution?

[alexmorbo]

Any news?

[Zaschii]

Are there any news how ICantBelieveItsNotValetudo can run with 2021.01.1?

[Hypfer]

Should be fixed by #46

[mikispag]

I made further improvements in my fork.

Feel free to port it back to upstream - in my fork, I decide to remove some features I don't need.

The fork:

• greatly optimizes the algorithm generating the map (based on #33)
  • On the same hardware, with a scale factor of 2, it can compute the map in ~400ms versus ~14000ms (~35x speedup).
• avoids unnecessary computations, caching full maps and map layers
• supports map compression
• supports base-64 encoded maps
• removes support for old binary maps, supporting Valetudo 2021.01.1+ only
• removes the webserver
• removes support for overlay/underlay images
• removes support for manual cropping.

[Hypfer]

@mikispag As far as I'm concerned, all these changes can be merged into this repo

[mikispag]

Oh, cool. Filed #47.

[sylvaindd]

Issue was fixed in #46

47 is working as well.

Thanks