Use SVG for the robot path and for placeholder images.

Hypfer / ICantBelieveItsNotValetudo

A Valetudo companion service which renders maps to pngs

Apache License 2.0

129 stars 80 forks source link

Use SVG for the robot path and for placeholder images. #53

Closed mikispag closed 3 years ago

Hypfer commented 3 years ago

Drawing map...
/app/lib/MapDrawer.js:140
            let svgPathImg = new Image();
                             ^

ReferenceError: Image is not defined
    at drawPath (/app/lib/MapDrawer.js:140:30)
    at MapDrawer.draw (/app/lib/MapDrawer.js:185:9)
    at Timeout._onTimeout (/app/lib/MqttClient.js:87:36)
    at listOnTimeout (internal/timers.js:554:17)
    at processTimers (internal/timers.js:497:7)

I'm not so sure about the test part

Hypfer commented 3 years ago

Okay, I was able to fix that. Unfortunately, for some reason, I was only able to get a very blurry svg path. Anways, since this is a static image and not a dynamic canvas there aren't many (if any) benefits to using svgs in this service so I've reverted the commit

mikispag commented 3 years ago

Wow, I am really sorry. My git post-receive hooks stopped working and I was testing an old checkout. Again, really sorry, there are many errors indeed in this pull request.