search

Hypfer / ICantBelieveItsNotValetudo

A Valetudo companion service which renders maps to pngs
Apache License 2.0
129 stars 80 forks source link

Add support for multiple configuration instances/robots #76

Closed ICantBelieveItsNotDerRohrbach closed 2 years ago

ICantBelieveItsNotDerRohrbach commented 2 years ago

What is it?

This pull request adds support for having multiple configuration instances in one server process. This resolves several problems for people with multiple robots.

  1. People using the HomeAssistant Add-On don't need to install multiple instances of the addon
  2. People with multiple Robots don't need to run multiple instances of this app -> They don't need to update and monitor multiple processes

This pull request does not add any breaking changes. Existing configurations will continue to work and the schema does not change for people with only one robot. For people with multiple robots it will be possible to wrap the current schema in an array and add multiple configuration instances to the file.

Why this implementation?

The current implementation has a focus on simple maintenance for the core developers of this project. It touches neither the webserver nor the mqttClient, while still being sufficent for people with multiple robots. It is not comfortable for the users though, because multiple configs have to be written and multiple ports are being opened. Either way I think this strikes a great balance between maintainability and usage, because not very many people will be using this feature.

What can be improved?

If you prefer other implementations or have any ideas or improvements, I am open for discussion and recommendations and hope for great team work.

Hypfer commented 2 years ago

Dude are you serious?

You're banned because you can't take a no yet you now reappear with a new account, ignoring the no wanting to do it anyways.

Do you really think that this will get you anywhere?

The new username is rather funny though. I like that

ICantBelieveItsNotDerRohrbach commented 2 years ago

Well sorry i wanted to contribute. I guess i'll have to maintain my fork then. I'll not bother you again

Hypfer commented 2 years ago

A contribution is aligned with the goals and vision of a project. This is no such thing.

This is just you not accepting a no. The Hassio add-on is not a supported way of running this software. Why would it be? That whole system is basically proprietary

ICantBelieveItsNotDerRohrbach commented 2 years ago

I accept that. Good thing i made it easy to maintain this for myself. I find it sad though that your vision is more important than your users. I just want to make my intentions clear, since you seem to have misunderstood me and this is not me wanting to force something into this project. This is me wanting to help other users out which have the same problem as me. I am fine. I am a dev and can maintain my own fork. But not everyone can and discoverability of one of 69 (nice) forks is also not great. I guess it's just for me then. This was my final message about this topic. I will not bother you with it again. I would appreciate it tough if you could unban me, so i can contact you, if i have another feature which is more aligned with your goals. Have a nice evening. And sorry again I was bothering you with this.

Hypfer commented 2 years ago

I find it sad though that your vision is more important than your users.

Why would I care?

To make money? I don't intend to monetize Valetudo. I don't need paying customers.

To be nice? I'm already spending hours every single day supporting people, enhancing Valetudo etc. I'm already being very nice.

Take a look at https://valetudo.cloud/ This is literally the first page you see when looking at Valetudo.

Quote:

Expectation Management

This project is the hobby of some random guy on the internet. There is no intent to monetize Valetudo now or in the future meaning that market share is irrelevant. Therefore, this is run as a zero compromises project.

This project is not user focussed. It is provided for free as open source to anyone but that's all. User satisfaction is no goal of Valetudo.

As Valetudo only exists because it is fun to maintain/improve/etc., any departure from this core policy would be the death of the project. It could be a slow death with the values slowly eroding in favour of monetization/data stealing/etc. but it would be a death either way.

I don't want Valetudo to die. I'm pretty sure that you don't want that either. Thus, please be mindful of that fact next time you're angry about your ideas being rejected because they don't fit the projects goals.

I'm not forcing anyone to use Valetudo. Therefore, no one can or should force me to care.

Just use the Cloud. Do what the manufacturer intended you to do. Bother the support. They're paid to care.

I am not and I don't want to be.