search

Hypfer / lovelace-valetudo-map-card

Display the map from a valetudo-enabled robot in a home assistant dashboard card.
MIT License
247 stars 36 forks source link

Rotating does not work without setting degrees #34

Closed zvldz closed 4 years ago

zvldz commented 4 years ago

Rotating does not work without setting degrees(ex: rotate: 1).

Error:

Cannot assign to read only property 'rotate' of object '#<Object>'

Breaking Changes in 0.106 (Freeze config). https://github.com/TheLastProject/lovelace-valetudo-map-card/blob/master/valetudo-map-card.js#L239

TheLastProject commented 4 years ago

Please update your card, you're using an old version. See #32 and #33.

zvldz commented 4 years ago

I'm using the latest version of the card.

TheLastProject commented 4 years ago

Still can't reproduce it, works fine for me on 0.106. So my guess is that you're still running an older version (probably just cached in your browser like in #33)

zvldz commented 4 years ago

Installed: becff16 Browser cache is cleared.

      - type: custom:valetudo-map-card
        entity: sensor.xiaomi_map
        rotate: -1                                                                                                                                                          
        map_scale: 1.5
        crop:
          top: 70
          bottom: 30
          left: 130
          right: 0
        min_height: 0

Okay, then I'll just add degrees to the settings.

TheLastProject commented 4 years ago

I tried your exact example given now and it just works for me.

zvldz commented 4 years ago

I double-checked everything. It's magic, it doesn't work for me. I'll add degrees, it'll be simpler. Maybe later it' ll be clear why it' s happening.

TheLastProject commented 4 years ago

Hey,

Sorry for closing this earlier. I wasn't aware the issue was actually newly introduced in Home Assistant 0.106.1 and didn't exist in 0.106.0. Home Assistant also didn't document a breaking change there. It's fixed now at least. Thank you for the report and I hope you will continue to report issues in the future.

zvldz commented 4 years ago

I had a ha 0.106.0 at the time. Thank you for fixing it, but I haven't had time to check it yet.