HyphaApp / hypha

Submission management software for open calls
http://docs.hypha.app/
BSD 3-Clause "New" or "Revised" License
69 stars 38 forks source link

As a manager, ability to undo previous actions in a workflow or on content, or revert back to previous states for proposals #1449

Closed fourthletter closed 5 years ago

fourthletter commented 5 years ago

Is your feature request related to a problem? Please describe. As a manager, ability to undo previous actions in a workflow or on content, or revert back to previous states for proposals. Related to #348

Is your feature request related to an existing functionality? Please describe. Staff is able to revert status in concept note, but not proposal stage.

Describe the solution you'd like Staff needs to revert: Final determination OR Accepted --> Ready for Final Determination Ready for Final Determination --> Ready For Discussion Ready For Discussion --> Advisory Council Review Advisory Council Review --> Ready For Discussion Ready For Discussion --> OTF Review OTF Review --> Proposal Received

Describe alternatives you've considered An alternative is remove restrictions for core functionalities like sending determinations from statuses. Staff member should be able to send a determination (need more info, dismiss, accept) in ANY status.

Priority

Affected roles

frjo commented 5 years ago

@fourthletter From what I can see most of these are already possible. It does not work for you? Can you giva a URL to a submission that has the problem?

fourthletter commented 5 years ago

@frjo Thank you for identifying it's Ready for Final Determination --> Ready For Discussion

It's particularly difficult for staff to navigate because the status change option is misleading.

frjo commented 5 years ago

If they are misleading something needs to change. Create a new issue where you describe the problem.

Sent with GitHawk

fourthletter commented 5 years ago

I found a few bugs related to reverting back to previous states for proposals:

Example1: https://apply.opentech.fund/apply/submissions/5213/ Example 1 is a test created on the live site. The submission is currently in the "Ready In Final Determination" but there isn't an option to revert backwards. [ ] Go to https://apply.opentech.fund/apply/submissions/5213/ [ ] Click on update status [ ] User could only accept or dismiss. [ ] User should be able to revert back to previous status.

Example2: https://test-apply.opentech.fund/apply/submissions/18/#submission-details Example3: https://test-apply.opentech.fund/apply/submissions/88/ Examples 2 & 3 are from the test site. These submissions could be reverted. However, there are two "Ready for Discussion" statuses so it's jump back further than the previous status.

Images appeared when I attempt to progress to a different status in above tests: image

image

frjo commented 5 years ago

@fourthletter

Example1: https://apply.opentech.fund/apply/submissions/5213/

Yes, this is on live where this code is not yet running.

Examples 2 & 3 are from the test site. These submissions could be reverted. However, there are two "Ready for Discussion" statuses so it's jump back further than the previous status.

I had put in the wrong state, post_proposal_review_discussion instead of post_external_review_discussion. I have updated the pr and pushed it out to test so now it should work.

Images appeared when I attempt to progress to a different status in above tests:

You are referring to the error messages, red background with white text?

This I can not reproduce. Can you see if @saoun see this as well?