Closed theskumar closed 6 months ago
Can we have the error message pop up on the "New password" field instead of the "New password confirmation" field?
Can we have the error message pop up on the "New password" field instead of the "New password confirmation" field?
let me take a stab at it. I believe it's the Django's default password change form.
Can we have the error message pop up on the "New password" field instead of the "New password confirmation" field?
I cross checked and the validation logic comes from the default ChangePassword View/Form from Django. So I would try avoid changing the position of the error message unless you have a strong opinion/need for it. Also, in the latest version of Django the code related to validation of passwords has been updated, so I would advice we don't implement a custom validate logic which will then need to be maintained.
Thinking out loud, the validation error messages in the screenshot is shown only after both the passwords match, so I think it might be too confusing to users.
Inline error messages
Fixes https://github.com/HyphaApp/hypha/issues/3842
Test Steps