HyphaApp / hypha

Submission management software for open calls
https://www.hypha.app
BSD 3-Clause "New" or "Revised" License
69 stars 38 forks source link

Partners that hold an applicant role have issues viewing comments with `Partner` visibility #3892

Closed wes-otf closed 6 months ago

wes-otf commented 6 months ago

Something I didn't consider previously was that given partners can also be applicants (and often are), there are issues that come with this as some partners were having applicant visibility on applications they were partners on. This is because the APPLICANT role is considered first in the following (L233): https://github.com/HyphaApp/hypha/blob/7ed9d365d9dbbaf0103cf8baa5a1970a5725f41f/hypha/apply/activity/models.py#L216-L236

even with this mediated and PARTNER being evaluated first, the partner would have the visibility of a partner on applications they submitted.