search

HyphaApp / hypha

Submission management software for open calls
https://www.hypha.app
BSD 3-Clause "New" or "Revised" License
67 stars 39 forks source link

How Hypha handle the partner feature #3915

Closed frjo closed 1 month ago

frjo commented 3 months ago

Related https://github.com/HyphaApp/hypha/pull/3913 and https://github.com/HyphaApp/hypha/pull/3893

The resent PRs to fix partner permissions etc. work well and solves issues that need solving.

But to me the solutions look a bit "messy" and non obvious.

I think OTF uses partners in a quite different manner from how the feature was built initially. And now we push and pull on it to make it do what OTF wants today.

I think the partner feature would work a lot better if we redesigned it from the ground up to conform to OTFs needs.

The UI and naming can stay the same so as not to confuse the users but we rebuilt/rethink the backend.

It is not a lot of code I think, more work with deciding what to code than to code it. The result would be a feature that does exactly what OTF needs and that are clear and easy to work with for future developers.

wes-otf commented 3 months ago

I'll also bring this up in the maintainers meeting tomorrow to see where their vision/usage of the partner role fits in this