Make paf and vendors details editable for active projects

HyphaApp / hypha

Submission management software for open calls

https://www.hypha.app

BSD 3-Clause "New" or "Revised" License

67 stars 39 forks source link

Make paf and vendors details editable for active projects #3924

Closed sandeepsajan0 closed 1 month ago

sandeepsajan0 commented 3 months ago

Fixes #3883 and #3908

Right now, PAF and Contracting information is only editable in Draft state. But with these changes, PAF and Contracting details are editable for active projects(*reviewer roles condition applied).

Test Steps

[ ] As a staff, pick any project with a status other than Complete(active project).
[ ] Look into the Project Documents section and try to edit Vendor Details(Contracting Information)
[ ] If there are no reviewer roles, PAF should be editable for active projects.
[ ] If there are reviewer roles then PAf can not be edited after or during approval.

wes-otf commented 2 months ago

I've got a question out regarding the applicant being able to edit - in the meantime @sandeepsajan0 can you toss some test steps on? then we can hopefully get this merged by the end of the week

sandeepsajan0 commented 2 months ago

@wes-otf I have added a few steps for its testing. It is not critical but just the permissions update to edit the PAF and Contracting Information.

sandeepsajan0 commented 1 month ago

@frjo Is this PR deployed to the test site? It doesn't seem to be working that way, it might have went down recently. If it is there then I might need to look into it again.

frjo commented 1 month ago

@sandeepsajan0 Thanks for the notice. Fixed now. I rebuilt the test site and missed merging this back in.

wes-otf commented 1 month ago

Works great! Thanks for the assists with the steps @sandeepsajan0!