All projects with the status of `Internal Approval` cannot be opened

HyphaApp / hypha

Submission management software for open calls

https://www.hypha.app

BSD 3-Clause "New" or "Revised" License

67 stars 38 forks source link

All projects with the status of `Internal Approval` cannot be opened #3945

Open wes-otf opened 1 month ago

wes-otf commented 1 month ago

While testing project features, I went to open a project in Internal Approval and that resulted in an error of 'internal_approval' is not in list, which looks to stem from the this code in the test branch. Didn't have a chance to dig too deep on it yet.

frjo commented 1 month ago

Adding an "PAF Reviewers Roles" (should also be renamed) fixes this issue.

We do not have a solution in place for projects that are being approved and the organisation desided to delete all the "PAF Reviewers Roles". They end up in a limbo.

I think we can see this as an edge case but would be good to have it just work in any case.