Hide staff identities from applicants & partners

HyphaApp / hypha

Submission management software for open calls

https://www.hypha.app

BSD 3-Clause "New" or "Revised" License

67 stars 38 forks source link

Hide staff identities from applicants & partners #3948

Open wes-otf opened 1 month ago

wes-otf commented 1 month ago

Fixes #3936. Hides staff identities and adds the new settings option of HIDE_STAFF_IDENTITY to make this option configurable. Also, in adding is_org_faculty I noticed is_apply_staff_or_finance which was only used in one place and felt redundant so I tossed it.

Test Steps

Testing w/ HIDE_STAFF_IDENTITY enabled

[ ] As an applicant role, submit an application
[ ] View your application and ensure you cannot see the lead
[ ] As a staff role, leave a comment on the submitted application
[ ] As the original applicant, ensure the staff comment appears as the organization name

Testing w/ HIDE_STAFF_IDENTITY disabled

[ ] As an applicant role, submit an application
[ ] View your application and ensure you can see the lead
[ ] As a staff role, leave a comment on the submitted application
[ ] As the original applicant, ensure the staff comment appears as the staff member's name

wes-otf commented 1 month ago

Drafting as I wanted to see if there was a way a migration could be created for this to make all previous Lead updated... activities to have the visibility of team? Looking at the tables I was struggling to see how I could correlate the activity_event table's type back to the activity_activity table to modify visibility. ie, all activity_activity items triggered by UPDATE_LEAD events would have their visibility changed to team. Digging more today but am open to any ideas!

Will also be adding unit tests & looking at the project side of this

frjo commented 1 month ago

Looks good!

We had staff named in some activities as well I think you mentioned. And the Lead name.

The list of reviews in the submission detail sidebar lists names as well I believe.

wes-otf commented 1 month ago

I rebased onto #3913 to be able to utilize the recipient email template context, so this is dependent on that.

All is just about set here, just need to figure out how to migrate those previous activities & write some unit tests

wes-otf commented 1 month ago

This should be ready to be tested - as mentioned before it's rebased onto #3913 so some of the diff comes from that (see here for commits just from this PR). Unit tests added to make sure the lead's name doesn't show anywhere in the project/submission detail views when identity hiding is enabled

wes-otf commented 3 weeks ago

@frjo this is ready to go on test

wes-otf commented 2 weeks ago

Also gonna toss this to the user testing team - they were the ones that expressed concern over this originally, wanna see if they can break it

wes-otf commented 1 week ago

@frjo can you push this to test when you get a sec? going to get it user tested so we can hopefully get it in soon

frjo commented 1 week ago

@wes-otf Updated test now.