Update Screening UI & UX

HyphaApp / hypha

Submission management software for open calls

https://www.hypha.app

BSD 3-Clause "New" or "Revised" License

67 stars 38 forks source link

Update Screening UI & UX #3955

Closed theskumar closed 1 month ago

theskumar commented 1 month ago

Use htmx
Update/fix behaviour
code cleanup - js, api, python views/forms

Fixes https://github.com/HyphaApp/hypha/issues/3873

https://github.com/HyphaApp/hypha/assets/236356/befc068a-864e-4ae2-a571-268f3fe288f7

Screenshot 2024-06-03 at 9  18 57@2x

Screenshot 2024-06-03 at 9  19 53@2x

Screenshot 2024-06-03 at 9  16 08@2x

Test Steps

[ ] Open a submission
[ ] check the behaviour for both applicant and staff
[ ] Check the status is displayed correctly in both "List" and "table" view of submission listing.

theskumar commented 1 month ago

Still need to update the test cases, but please review ui and ux of screening.

frjo commented 1 month ago

Screening decisions can be long so I think we need to allow wrapping. Can we also make the padding for the options the same as for the heading "Options".

This text is not needed I think.

Skärmavbild 2024-05-31 kl 13 34 02

frjo commented 1 month ago

If you pick a none default option it is saved to the database in the submission all tables the submission still show as "Awaiting screening".

The reason is that these functions are used:

https://github.com/HyphaApp/hypha/blob/8b69c168dc33323bb049e180640d092ddaa6935a/hypha/apply/funds/models/submissions.py#L946-L956

frjo commented 1 month ago

I really like the UI for this. It feels slick and very functional!

theskumar commented 1 month ago

Screening decisions can be long so I think we need to allow wrapping.

I'll enable wrapping.

Can we also make the padding for the options the same as for the heading "Options".

The padding left is to allow for the ✔️ mark to show up. It follow the same behaviour as the dropdown in submission list view. I would suggest we keep as it is. Unless you think otherwise. Let me know, I'll remove.

Update: Looks like there was bug on the padding. Updated the code in https://github.com/HyphaApp/hypha/pull/3955/commits/6cae3c36df01ca1f71e6e49b8103cd09735ac93a

Screenshot 2024-05-31 at 7  46 53@2x

theskumar commented 1 month ago

If you pick a none default option it is saved to the database in the submission all tables the submission still show as "Awaiting screening".

Should we update the submission table to display the currently selected screening option instead?

theskumar commented 1 month ago

This text is not needed I think. https://github.com/HyphaApp/hypha/pull/3955#issuecomment-2142012064

Removed in https://github.com/HyphaApp/hypha/pull/3955/commits/0e696d964bbf064cc31fbf6c3eb3b21c2fefce65

theskumar commented 1 month ago

Managed to update the test-cases, made them work with the new htmx flow.

wes-otf commented 1 month ago

This is came out so good! In testing it was really nice to use, fun in way. Nice work @theskumar!