search

HyphaApp / hypha

Submission management software for open calls
https://www.hypha.app
BSD 3-Clause "New" or "Revised" License
67 stars 38 forks source link

Sorting header applied on more submissions tables #3974

Open bickelj opened 1 month ago

bickelj commented 1 month ago

Issue #3973

Test Steps

bickelj commented 3 weeks ago

The admin view shows to much, adds batch actions etc. Not suitable for reviewers.

I suggest instead setting orderable = True for ReviewerSubmissionsTable.

It seems to work, nice clean suggestion!

Edit: but oh, no, tests fail:

FAILED hypha/apply/dashboard/tests/test_views.py::TestReviewerDashboard::test_no_submissions_waiting_for_review - TypeError: Cannot reorder a query once a slice has been taken.
FAILED hypha/apply/dashboard/tests/test_views.py::TestReviewerDashboard::test_submission_assigned_but_not_in_external_review_status - TypeError: Cannot reorder a query once a slice has been taken.
FAILED hypha/apply/dashboard/tests/test_views.py::TestReviewerDashboard::test_waiting_for_review_with_count - TypeError: Cannot reorder a query once a slice has been taken.