Closed wes-otf closed 3 months ago
tomorrow will add a quick blurb to the docs about adding analytics and putting the exposed JS functions but otherwise this is ready for review
@frjo I swapped the analytics toggle for the same buttons that are on the front page as suggested - definitely makes more sense.
Thanks for that feedback! Totally agreed with all. Bold white definitely makes it stand out quite a bit more.
@frjo #3994 breaks the styling of this - should I rebase onto that?
@wes-otf Most likely only the new media-query breakpoints needs updating.
yeah it was, I rebased onto #3994 and all looks good now. This was user tested yesterday and aside from the media breakpoints all was good
Fixes #3925. TLDR:
Learn More
option where users can read more about the essential & analytic cookies, and toggle analytics specifically.Demo
Desktop
with analytics cookies
https://github.com/HyphaApp/hypha/assets/145372368/a06942f9-9e99-4113-8903-dc2695dd7787
without analytics cookies (default)
https://github.com/HyphaApp/hypha/assets/145372368/0ba27988-22ba-4267-8945-6dad4a125e1d
Mobile
with analytics cookies
https://github.com/HyphaApp/hypha/assets/145372368/f9185f60-9912-401a-855e-2f37315c7f2b
without analytics cookies (default)
https://github.com/HyphaApp/hypha/assets/145372368/2b90bd51-f5de-4e68-8e24-1e4852439ed9
Test Steps
Analytics cookie testing
Settings
->Cookie Banner Settings
, ensure the analytics cookie message is enabled and has content in theinformation to be displayed under "Learn More"
boxLearn More
Ok
Essential cookie testing
Settings
->Cookie Banner Settings
, ensure the analytics cookie message is disabledOk
closes the promptReactivitity testing