Open wes-otf opened 1 week ago
rebased onto #3948 to use those features so some of the diff may be duplicated - code changes in this PR can be found here
This is ready for review. I was going to add some unit tests for the view_partials
, does anyone have previous examples of this they could toss my way so I could have an example for the review sidebar? @theskumar?
Fixes #3240. Adds
HIDE_IDENTITY_FROM_REVIEWERS
config option to hide the identities of staff & applicants from external reviewers. This also hides reviews that don't have visibility set toreviewer
from the sidebar as that seemed ore intuitive.There is also a fix here for the
Updated
field of the application where the original author will always be specified as the application editor even if someone else updated it. This is an edge case but will be helpful as we implement things like #3919.Test Steps
private
Reviews & assignees
sidebarreviewers