HyphaApp / hypha

Submission management software for open calls
https://www.hypha.app
BSD 3-Clause "New" or "Revised" License
67 stars 38 forks source link

Hide PII from external reviewers, along with private reviews #4018

Open wes-otf opened 1 week ago

wes-otf commented 1 week ago

Fixes #3240. Adds HIDE_IDENTITY_FROM_REVIEWERSconfig option to hide the identities of staff & applicants from external reviewers. This also hides reviews that don't have visibility set to reviewer from the sidebar as that seemed ore intuitive.

There is also a fix here for the Updated field of the application where the original author will always be specified as the application editor even if someone else updated it. This is an edge case but will be helpful as we implement things like #3919.

Test Steps

wes-otf commented 1 week ago

rebased onto #3948 to use those features so some of the diff may be duplicated - code changes in this PR can be found here

wes-otf commented 5 days ago

This is ready for review. I was going to add some unit tests for the view_partials, does anyone have previous examples of this they could toss my way so I could have an example for the review sidebar? @theskumar?