search

HyphaApp / hypha

Submission management software for open calls
https://www.hypha.app
BSD 3-Clause "New" or "Revised" License
67 stars 38 forks source link

Partially filling out reviewers when there are multiple reviewer roles fails to save #4020

Open frankduncan opened 1 week ago

frankduncan commented 1 week ago

Describe the bug

When you have 3+ reviewer roles, and you fill out only one reviewer for a submission, saving fails. This is due to the "duplicate reivewers" check working on the "None" object passed in by the "---" selections

To Reproduce

Steps to reproduce the behavior:

  1. Create 3+ reviewer roles
  2. Set only one reviewer on a submission when updating reviewers
  3. Save
  4. Shift-Refresh page to ensure browser did not cache selections (or navigate away and back)
  5. Open up update reviewers, see non eare saved

Expected behavior

The one reviewer is saved correctly

Priority

Affected roles

Desktop (please complete the following information):

Additional context

PR incoming

frjo commented 1 week ago

Good to get this fixed, this bug must be many years old.

frankduncan commented 4 days ago

Another PR is coming that also fixes this for batch reviewer changes! The code is in a different place but has the same error.