search

HyphaApp / hypha

Submission management software for open calls
https://www.hypha.app
BSD 3-Clause "New" or "Revised" License
67 stars 38 forks source link

Remove None reviewers from validation #4021

Open frankduncan opened 1 week ago

frankduncan commented 1 week ago

Fixes #4020

This was caused by an issue where the "---" (None) reviewers were causing the validation to fail, meaning that you had to fill out n-1 reviewers in the submission page in order for the save to go through.

The solution was to only check for duplicates with reviewers that were selected.

frankduncan commented 4 days ago

This has been updated with a second commit relating to the batch reviewer change code. Let me know if you want me to squash them!

frjo commented 4 days ago

@frankduncan No need, we use "Squash and merge" on all PRs in any case.

Rader prefer that a PR has separate commits when new code is added, easier to follow the work.