Closed sandeepsajan0 closed 2 weeks ago
Another way as Fredrik suggested to make the trash visible only by hovering on the row:
https://github.com/user-attachments/assets/0d4eb3fd-4487-41e9-86bb-10d5627f824c
@frjo @theskumar @wes-otf Let me know if it looks better than the screenshots in PR description. Also, we need to think about differentiating between single user task and group task for deletion like right now I use light red trash and dark red trash with different msg and tooltip.
Updated: It shows up on hover
small fixes around usage on mobile but other than that all looked good in testing! once those are set I think we can merge it. nice work @sandeepsajan0!
@frjo @theskumar As we discussed in dev meeting use x-mark or checkmark instead of trash icon with both primary and black and white buttons. Here are the possible options we can choose:
All blue/primary buttons
Black and white/ transparent buttons
x-marks with primary buttons in place of trash icon
x-mark with transparent buttons(h-24 and w-24)
check icon with primary buttons
check mark with transparent buttons
I lean towards option 4.
I also like 4! For me it weirdly makes more sense to have the x
on the right of the View
button too. That might be my personal preference though
For me it weirdly makes more sense to have the x on the right of the View button too.
@wes-otf At first, I put it there but then we thought it is better not to make it directly visible or attention seeker so decided to show the x mark only on hover. And if we show it in right on hover there will be a little UI shift so we decided to show it left of View button.
@wes-otf I hide the draft or task type for smaller screen(<640px), it looks good now even with 375px.
For bigger screens:
@frjo It is ready for re-testing with x-mark and transparent buttons and is usable on mobile.
On test now and I thinks it looks and works really well.
One small change, can we have the tool tip say "Remove task" instead of only "Remove"? This makes in clear that the submission, determination etc. is not removed, only the task itself.
Fixes Manual task removal issue. Two colors trash because of single user task and user group task.
Msg on removing single-user task.
Msg on removing group task.
Test Steps