Update modals to use htmx/alpine

HyphaApp / hypha

Submission management software for open calls

https://www.hypha.app

BSD 3-Clause "New" or "Revised" License

67 stars 39 forks source link

Update modals to use htmx/alpine #4053

Closed theskumar closed 2 weeks ago

theskumar commented 1 month ago

Delete modal
Update status modal
update reviewer
Archive/unarchive modal and view/logic
Create reminder modal
update reminder block design
Add modal title component
Django messages as toast for htmx request
[x] update lead modal response
[x] meta term modal
[x] new project modal
[x] partner update modal
Adds new htmx based handler for django-message-framework and display them as toast

Fixes #3391

Test Steps

[ ] Check above update modals work properly

theskumar commented 1 month ago

I do not think the modals should close when clicking the background, omnly when a button is pressed.

Yes. that can be made possible.

Edit: fixed in https://github.com/HyphaApp/hypha/pull/4053/commits/850a50ea6fbeeaba7a2bd178518d02cb1e087356

theskumar commented 1 month ago

This is good to review now. I've updated/fixed the meta terms display and forms. It should correctly fill the values in edit now.

Screenshot 2024-07-22 at 8  01 31@2x

theskumar commented 1 month ago

I'll fix over the failing test, the modal for the batch actions are not update, at the table view will be replaced soon in my next PR.

frjo commented 4 weeks ago

@theskumar Some minor issues with test. Seem to be looking for class names so might be an easy fix.

theskumar commented 4 weeks ago

@frjo Updated test cases.

theskumar commented 4 weeks ago

rebased with latest main.

frjo commented 3 weeks ago

Performance improvements:

Fewer db queries, 30-40% less.
Lower CPU time: 20-30% improvement.
Page load time: 10-15 % improvement.

wes-otf commented 2 weeks ago

This is fantastic! Testing went really well and everything looks much more slick. The only very minor issue I saw was the reminder toast showed twice upon creation but looking at the code that may be a reminders specific issue. Screenshot 2024-08-08 at 10 46 29

@frjo if it's determined that requires a separate issue this is ready to be merged

theskumar commented 1 week ago

This is fantastic! Testing went really well and everything looks much more slick. The only very minor issue I saw was the reminder toast showed twice upon creation but looking at the code that may be a reminders specific issue.

This is probably because it's specifically being asked to display and other one is via the django messages framework through the activity feed route. I think it should be quick and safe to remove one of them.

frjo commented 1 week ago

Added new issue for reminder alter bug. https://github.com/HyphaApp/hypha/issues/4082