Closed danblah closed 5 years ago
@danblah This is some work I believe. Setting up a separate fund/round/forms for this is of cource possible but I assube that is not an option.
You want to add three application forms to a fund. One concept note form . Two proposal forms, one small and one large. Then when an Concept note is invited for a proposal the system shoul look at the amount requested and for 100k or less pick the small form and for larger amounts pick the larger form.
In another issue you also mentioned wanting to allow the lead to pick between the different proposal forms manually when progressing an application, is that still so?
Currently the field in the concept note that asks for the amount is also not specifically in $ so we would need to change that if we want to use that value here.
Would this be easier if which proposal to create and go to next was a manual process? maybe something that a manager selects/checks at the invite to proposal status update?
How about this workflow...
@frjo, bumping this.
Adding this to the mini sprint @frjo and @fourthletter cause its needed. We should probably start a discussion here on how best to do this.
@danblah I think your implementation in https://github.com/OpenTechFund/opentech.fund/issues/717#issuecomment-448318747 is a reasonable approach.
There is an assumption that each phase has 1 form associated with it, I'll need to have a look at how much this would need to change. There is a helper method associated with the form selection for applications so shouldn't be too onerous.
I think we should address this process in two tickets:
MustIncludeBlocks
e.g. ValueBlock
and a gt/lt selector for variing the value.I was pondering a simpler solution with the field groups + trigger fields we added some time back. But for this separate forms is probably better.
Initial work for this is for Todd to outline implementation plan for this work in enough detail so that it can potentially be undertaken by someone other than him.
As the application holds a reference to the form that the user is responding to we only need to make the choice of which forms to use once. So the bulk of this work will focus on storing the form-stage data and the ability to then vary that form on progression. I have outlined below the various changes that are needed as i see them.
Add in the concept of a stage to the application model. This will involve adding in some concept of stage on the model definition.
IntegerField
which can be used to represent the Stage that the form is associated with. However this is not a nice user experience.
Add in the ability to vary the destination form from the determination page.
Pass the chosen form from the determination view into the stage progression.
perform_transition
through from here.
progress_application
method can then be updated to pass the form chosen through to the get_defined_fields
get_defined_fields
will need to be updated to handle the choice between multiple stages where currently it always assumes one form per stage
@Parbhat I talks this over with @saoun, @fourthletter and @danblah in a meeting last week and this is what got decided:
Requirements look good. Thanks.
@danblah @saoun @fourthletter This is now ready to test on https://test-apply.opentech.fund. I believe @Parbhat have implemented it really nicely.
Dearest @frjo I've added 2 stage proposal forms to 1) IFF [https://test-apply.opentech.fund/admin/pages/822/edit/?next=/admin/funds/round/] and 2) Rapid Response [https://test-apply.opentech.fund/admin/pages/823/edit/?next=/admin/funds/round/]
While these forms are almost perfect in every way, how do I add forms to the "No, I'm smaller than a bread box" option?
Example: https://test-apply.opentech.fund/rapid-response-archive-fund/
@fourthletter That is not how it's supposed to work. I have set up an example according to my comment above on test now.
This is what I did:
You can now go to https://test-apply.opentech.fund/apply/submissions/76/ and invite it to a proposal.
On the Determination form there are a new popup meny at the top where you can pick one of the proposal forms that was added to the Fund in step 1.
@frjo I tested this issue and results were successful. Thanks!
[] Staff sees new popup menu with two different proposals options on determination form [] Staff sends out proposal option A to applicant A [] Staff sends out proposal option B to applicant B [] Both applicants received correct proposals. [] Applicants were able to submit proposals to system
My usability concern is that it is not clear whether an individual received a particular application after the determination message has been sent. For example, I do not know if an applicant received the long proposal, short proposal, fellowship, etc. unless I have a clear grasp of the questions associated with the application
@frjo and @todd-dembrey, not sure how big/small this is. in the previous app, a concept note with the amount value of 100k or less was assigned a less onerous form to complete when invited to proposal. can we bring this back quickly?