search

Hyphen-ated / RebirthItemTracker

Uses the log.txt file to track item pickups in Binding of Isaac: Rebirth.
BSD 2-Clause "Simplified" License
121 stars 26 forks source link

Changes to add all transformations to tracker #105

Closed BrandonNowlin closed 8 years ago

BrandonNowlin commented 8 years ago

NuRelic Changes: Big Picture: Added all transformations to the tracker and gave them variables that can be referenced for the description on the user-side Added "spun" and "leviathan" to the default status message Added Transformations: Bob Conjoined Fun Guy Leviathan Oh Crap Seraphim Spun Yes, Mother Super Bum Beelzebub

Specifics: options.json: Added "/ Leviathan: {leviathan} / Spun: {spun}" options_default.json: Added "/ Leviathan: {leviathan} / Spun: {spun}" overlay text reference (Folder): Added transformation files, defaulted them to 0 src > game_objects > item.py: Added transformations to comment pertaining to properties accessible src > game_objects > state.py: Added: One set for each transformation Check each item for a transformation, if it is one of them, add that item to the set src > view_controls > overlay.py Added: Check on update_stats to check for each transformation Changed format_guppy to format_transformation and changed calls to function in both overlay.py and view.py src > view_controls > view.py Added (to keep comments accurate):

Draw seed/transformation text:

        Fill the dictionary with each transformation 
        Add check in "shown" for each transformation
items.json:
    Beelzebub Added with "beelzebub": true to the following:
        ???'s Only Friend (320)
        BBF (272)
        Best Bud (274)
        Big Fan (279)
        Distant Admiration (57)
        Forever Alone (128)
        Halo Of Flies (10)
        Hive Mind (248)
        Skatole (9)
        Smart Fly (264)
        The Mulligan (151)
        Infestation (148)
        Friend Zone (364)
        Lost Fly (365)
        Papa Fly (430)
        Obsessed Fan(426)
    Bob Added with "bob": true to the following:
        Bob's Rotten Head (42)
        Bob's Brain (273)
        Bob's Curse (140)
        Ipecac (149)
    Conjoined Added with "conjoined": true to the following:
        Brother Bobby (8)
        Harlequin Baby (167)
        Headless Baby (269)
        Little Steven (100)
        Mongo Baby (322)
        Rotten Baby (268)
        Sister Maggy (67)
    Fun Guy Added with "funguy": true to the following:
        God's Flesh (398)
        Mini Mush (71)
        Magic Mushroom (12)
        Odd Mushroom (Thin) (120)
        Odd Mushroom (Large) (121)
        1up! (11)
        Blue Cap (342)
    Leviathan Added with "leviathan": true to the following:
        The Nail (83)
        The Mark (79)
        The Pact (80)
        Pentagram (51)
        Spirit Of The Night (159)
        Maw Of The Void (399)
        Abaddon (230)
        Brimstone (118)
    Oh Crap Added with "ohcrap": true to the following:
        Flush! (291)
        The Poop (36)
        E. Coli (236)
    Seraphim Added with "seraphim": true to the following:
        The Bible (33)
        Dead Dove (185)
        Guardian Angel (112)
        Holy Grail (184)
        Holy Mantle (313)
        Mitre (173)
        Rosary (72)
        Sworn Protector (363)
        The Halo (101)
    Spun Added with "spun": true to the following:
        Experimental Treatment (240)
        Growth Hormones (70)
        Roid Rage (14)
        Speed Ball (143)
        Synthoil (345)
        The Virus (13)
    Yes, Mother? Added with "yesmother": true to the following:
        Mom's Bottle Of Pills (102)
        Mom's Bra (39)
        Mom's Pad (41)
        Mom's Wig (217)
        Mom's Eye (55)
        Mom's Purse (139)
        Mom's Contact (110)
        Mom's Knife (114)
        Mom's Heels (30)
        Mom's Eyeshadow (200)
        Mom's Perfume (228)
        Mom's Key (199)
        Mom's Lipstick (31)
        Mom's Underwear (29)
        Mom's Coin Purse (195)
        Mom's Pearls (355)
    Super Bum Added with "superbum": true to the following:
        Bum Friend (144)
        Dark Bum (278)
        Key Bum (388)
viroulep commented 8 years ago

Hey,

I have a few comments on the PR, not really on the content as everything seems to be handled, but more on the form. First of all there is three commits, and two of them are cancelling each other :) I guess Hyphen won't want to merge that "as is" but I may be wrong. Do you have the technical knowledge on how to fix that ? If not, do you want/need help or are you fine with someone else doing it for you ?

For the other things I'm going to comment directly in the commit, that will be easier. Same here, if you don't know what I'm talking about in these comments, do you and @Hyphen-ated mind if I cherry-pick the last commit and clean+"pythonify" it ?

Zamiell commented 8 years ago

This PR looks like it is based on an old version of the tracker. Can you rebase the PR on the latest version so that it doesn't kill my changes?

BrandonNowlin commented 8 years ago

I'll pull the latest version (I thought I did but I might have made a mistake) and fix the issues mentioned above. I appreciate the feedback and I think I can take care of it.

Hyphen-ated commented 8 years ago

pulling won't do anything; this code is already based on the latest version as far as git is concerned. the issue is that it looks like you erased some existing code. (maybe you copy pasted an old version of the whole file at some point?)