search

HypixelDev / PublicAPI

Official Java implementation of the Hypixel Public API.
https://api.hypixel.net
MIT License
539 stars 152 forks source link

[Skyblock] Swapped values #199

Closed Strengthless closed 4 years ago

Strengthless commented 4 years ago

In the skyblock/bazaar/product endpoint, the path product_info.sell_summary returns the current top 30 buying orders, not the selling orders.

This issue also affects product_info.quick_status.buyPrice and product_info.quick_status.sellPrice etc.

It seems that all the sell values and buy values are swapped.

PoC: 2020-03-14_00 46 40 Untitled-1

I'm not sure if this was intended, but it is definitely confusing and should be changed.

skyblockz commented 4 years ago

The whole economy of bazaar is controlled by players, which this could happen when there are more people who buy a lot of items for higher prices than selling, this should disappear by time when the economy wants to chill

Strengthless commented 4 years ago

The whole economy of bazaar is controlled by players, which this could happen when there are more people who buy a lot of items for higher prices than selling, this should disappear by time when the economy wants to chill

This was not the case. I have now included a better PoC to back up my point.

Minikloon commented 4 years ago

It's cause internally the sellPrice is computed from the sell summary. I don't think the API will change.