search

HypixelDev / PublicAPI

Official Java implementation of the Hypixel Public API.
https://api.hypixel.net
MIT License
533 stars 151 forks source link

[Suggestion] api.hypixel.net/key?key=[YOURKEY] - shouldn’t count towards the 120/m limit #279

Closed ugcodrr closed 4 years ago

ugcodrr commented 4 years ago

Title.

If you were to go to https://api.hypixel.net/key?key=[YOURKEY] and refresh the page you will see the queries within the last minute go up for each refresh.

Another solution or way to do this could be including it in the header as described in #248, or adding it somewhere into all responses at the bottom or something.

Thank you 👍

shadowtime2000 commented 4 years ago

I agree, but I cannot see an way that hitting that endpoint would actually be that useful it would need to be set to not count towards the 120/m limit.

robere2 commented 4 years ago

I agree, but I cannot see an way that hitting that endpoint would actually be that useful it would need to be set to not count towards the 120/m limit.

The biggest benefit is there's then no downside to checking how many more requests you can send until you're rate limited. This would be a non-issue if the API provided this information in headers, i.e. IETF draft-polli-ratelimit-headers

ConnorLinfoot commented 4 years ago

This endpoint still requires the data to be retrieved and is why it still counts as an API use. The better solution as stated would be the header which is already suggested in another issue.