Merged HypixelAPI::get and HypixelAPI::requestResource and added overload for passing parameters as Map<String, Object> [Enhancement]

HypixelDev / PublicAPI

Official Java implementation of the Hypixel Public API.

https://api.hypixel.net

MIT License

538 stars 152 forks source link

Merged HypixelAPI::get and HypixelAPI::requestResource and added overload for passing parameters as Map<String, Object> [Enhancement] #301

Closed chriptus13 closed 3 years ago

chriptus13 commented 4 years ago

Added a new method to allow passing parameters as Map<String, Object> (as mentioned in the TODO at HypixelAPI)
Changed some parameter names due to semantics
Added a more generic method HypixelAPI::get(String, Map<String, Object>) to allow merging get and requestResource
Deleted HypixelAPI::requestResource, HypixelAPI::getResource(String) now uses HypixelAPI::get(String) (removed duplicated code for executor submission)

chriptus13 commented 4 years ago

I think maybe the parameters Map should be Map<String, String>?

ConnorLinfoot commented 3 years ago

I believe this is no longer needed with 4.0, please feel free to re-open and update if you believe it would still be useful but there is the new HTTPQueryParams object now.