HypixelDev / PublicAPI

Official Java implementation of the Hypixel Public API.
https://api.hypixel.net
MIT License
533 stars 151 forks source link

Add more filtering options on Auctions Endpoint #434

Closed franhida closed 3 years ago

franhida commented 3 years ago

It would be nice to have similar filtering options in the API as it can be done the in-game Auction House. I would like to propose some more filtering options as query params:

The full examples of the options above would be as follows:

Of course, mixing the params should be allowed as well.

Should I think any further options, they will be posted in this very issue.

ConnorLinfoot commented 3 years ago

Unfortunately, we don't have intentions at this time to implement filters to this endpoint. As usual, we like to keep processing to a minimum for performance reasons. This specific endpoint is already handling millions of requests per day and we can only handle that nicely due to heavy caching.

franhida commented 3 years ago

That's a pity. Thanks for the quick response nonetheless. Does this same response apply to all the endpoints or just this one in particular? Thanks again @ConnorLinfoot

ConnorLinfoot commented 3 years ago

It basically goes for anything where we believe the processing is too much or just not required. We also do some processing for example on SkyBlock Profiles to clean up the output a little compared to the database but this was an edge case where it made sense.