HypixelDev / PublicAPI

Official Java implementation of the Hypixel Public API.
https://api.hypixel.net
MIT License
535 stars 152 forks source link

Add missing guild information #466

Closed TheNullicorn closed 2 years ago

TheNullicorn commented 2 years ago

The Java API is missing a number of guild features (such as ranks, as pointed out in #463), so this PR aims to add those, as well as refactoring areas of the Java API relating to guilds.

GuildReply.java

Banner.java

GetGuildExample.java

GuildAchievement.java

Resolves #463

EDIT When making this, I purposefully left out 3 fields in particular. The reason for this is that they represent the guild's internal state, and I wouldn't be very surprised if the devs eventually chose to hide/remove them (like they have in the past with certain fields in the "player" endpoint). These fields are:
  • guild.chatMute
  • guild.members[i].mutedTill
  • guild.hideGmTag
If there's any demand for these fields and the devs can confirm that they're intended to be public, I'd be fine adding them. But I'd rather not add them in the first place if there's any chance of them suddenly becoming inaccessible and breaking someone's app.