search

HypixelDev / PublicAPI

Official Java implementation of the Hypixel Public API.
https://api.hypixel.net
MIT License
535 stars 152 forks source link

Useless skyblock category in guildExpByGameType #468

Closed tronving closed 2 years ago

tronving commented 2 years ago

A fix will be deployed for Pit, however, at this time SkyBlock is part of Prototype and this is correct to how its supposed to be categorized.

Originally posted by @ConnorLinfoot in https://github.com/HypixelDev/PublicAPI/issues/467#issuecomment-915150762

Hey again, sorry to recreate this thread, but I wanted to say that I understand that skyblock is a part of prototype, and I was merely suggesting that the "skyblock" key would be removed, as it is useless.

Also, English is not my first language, so I apologize if the grammar I'm using is incorrect.

tronving commented 2 years ago

skyblockexample

TheNullicorn commented 2 years ago

Same goes for LEGACY, SMP, and (for some reason) REPLAY

ConnorLinfoot commented 2 years ago

I don't think we need to remove these keys as they are automatically populated by our registered gametypes and it does no harm as you can check the value.