search

HypixelDev / PublicAPI

Official Java implementation of the Hypixel Public API.
https://api.hypixel.net
MIT License
535 stars 152 forks source link

Enchanted Books and essence missing ExtraAttributes id field #560

Closed csjh closed 1 year ago

csjh commented 1 year ago

All other items on the bazaar have an ExtraAttributes id field denoting what their identifier is on the /skyblock/bazaar endpoint except for enchanted books and essence with the new update.

Would it be possible to add that to them (at least enchanted books) for the sake of standardization?

ConnorLinfoot commented 1 year ago

Can you provide more information on what field you are referring to? I'm not noticing a difference between the enchants vs other items.

Picsou993 commented 1 year ago

I think what they are talking about is the NBT data of the item itself. If you get the NBT using eg inv_content from the skyblock/profile endpoint, all items have an id field in their ExtraAttributes field. However for enchanted books the field id in ExtraAttibutes is only retrieving the id of the enchanted book without the value of the enchant. So it's not possible to use the id to get this key to get the exact book for the bazaar endpoint.

image image Here id is ENCHANTED_BOOK but I believe they would like it to be ENCHANTMENT_FEATHER_FALLING_6.

ConnorLinfoot commented 1 year ago

In that case this isn't an issue within the API and is unlikely to be changed. The NBT data in profiles is just raw data, so whatever the game uses/needs is what is there.

csjh commented 1 year ago

In that case this isn't an issue within the API and is unlikely to be changed. The NBT data in profiles is just raw data, so whatever the game uses/needs is what is there.

In that case, would it be possible to add the names of the items to the endpoint? As it stands, some items aren't listed on the /resources/skyblock/items endpoint so adding names to /skyblock/bazaar would help