HypixelDev / PublicAPI

Official Java implementation of the Hypixel Public API.
https://api.hypixel.net
MIT License
535 stars 151 forks source link

Data inconsistencies between two endpoints. #569

Closed ghost closed 12 months ago

ghost commented 1 year ago

Hi.

I have noticed the object name of a few games in /resources/achievements violating the GameTypes, therefore making it incompatible with /resources/games.

Example:

While it is a minor impact, having to write a list will increase the file size for a project.

It'd save more space by fetching /resources/achievements and having them pre-populate the page. (Like how Hypixel does it here: [1])

Then - Compare data from /player to highlight the unlocked achievements while keeping the locked ones around.

mdashlw commented 1 year ago

Changing the keys in /resources/achivements would mean changing it in /player under achievements and achievements_one_time (or whatever it's called), which likely won't happen

ConnorLinfoot commented 12 months ago

Achievement handlers aren't strictly tied to a game and internally are just provided for each game manually. This is why there are non-games there, such as "easter".