search

HypoPG / hypopg

Hypothetical Indexes for PostgreSQL
https://hypopg.readthedocs.io
Other
1.39k stars 59 forks source link

Fix PartitionedChildRelInfo #34

Closed yuzupy closed 5 years ago

yuzupy commented 5 years ago

I fixed the way of making root->pcinfo for pg10.

rjuju commented 5 years ago

Thanks. I see that root->pcinfo_list is now correctly set, however I still hit an assert running the regression tests in add_paths_to_append_rel(), at least for multi level partitioning:

(gdb) p root->pcinfo_list 
$1 = (List *) 0x55764c6230a8
(gdb) p partitioned_rels 
$2 = (List *) 0x0
(gdb) p debug_query_string 
$3 = 0x55764c4d5e20 "EXPLAIN (COSTS OFF) SELECT * FROM hypo_part_multi;"
yuzupy commented 5 years ago

Oh, I'm sorry. I made root->pcinfo_list in the same way as core. However, in the current hypopg, add_paths_to_append_rel() is called for non-root tables although this function is called for only root table. As a result, we hit an assert. I'll try to fix that.

rjuju commented 5 years ago

Perfect, thanks a lot!