search

HypothesisWorks / hypothesis

Hypothesis is a powerful, flexible, and easy to use library for property-based testing.
https://hypothesis.works
Other
7.58k stars 587 forks source link

Fix deploy job #4150

Closed tybug closed 2 weeks ago

tybug commented 2 weeks ago

This pull fixes timeouts on our deploy CI job, on as seen as far back as dec 2023 (CI job) - or more recently, with logs. I tracked this down to a hang on building .. jsonschema:: in observability.rst, only when using text mode (as our deploy script does). We don't need to build the whole docs there, so I didn't dig further and sidestepped the issue by only building the necessary changes.

In passing, I've also removed --keep-going, which seems redundant as of sphinx 8.1 (we are on 8.1.3):

Changed in version 8.1: sphinx-build no longer exits on the first warning, meaning that in effect --fail-on-warning is always enabled. The option is retained for compatibility, but may be removed at some later date. https://www.sphinx-doc.org/en/master/man/sphinx-build.html#cmdoption-sphinx-build-keep-going

And I have attempted a speculative and untested fix for #3756 by fixing the Bearer format, which does not have a colon according to github's docs. Possibly github parses it fine anyway, but it can't possibly be worse than the status quo of "releases dont work".

tybug commented 2 weeks ago

woo! I'm pleasantly surprised that the token change was all it took here. Any volunteers to backfill the releases? xD https://github.com/HypothesisWorks/hypothesis/releases/tag/hypothesis-python-6.115.6

Zac-HD commented 2 weeks ago

🎉 exciting times!

I probably wouldn't bother backfilling, though anybody who wants to is welcome to do so (or write a script I can run at some point I guess)