Hyundai-Kia-Connect / kia_uvo

A Home Assistant HACS integration that supports Kia Connect(Uvo) and Hyundai Bluelink. The integration supports the EU, Canada and the USA.
MIT License
427 stars 85 forks source link

Climate broken: AttributeError: 'Vehicle' object has no attribute 'region' #125

Closed JamesT42 closed 2 years ago

JamesT42 commented 2 years ago

Hi!

climate service is broken in latest version

2021-11-13 14:21:37 ERROR (MainThread) [homeassistant.helpers.script.websocket_api_script] websocket_api script: Error executing script. Unexpected error for call_service at pos 1: 'Vehicle' object has no attribute 'region'
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/script.py", line 371, in _async_step
    await getattr(self, handler)()
  File "/usr/src/homeassistant/homeassistant/helpers/script.py", line 571, in _async_call_service_step
    await service_task
  File "/usr/src/homeassistant/homeassistant/core.py", line 1495, in async_call
    task.result()
  File "/usr/src/homeassistant/homeassistant/core.py", line 1530, in _execute_service
    await handler.job.target(service_call)
  File "/config/custom_components/kia_uvo/__init__.py", line 91, in async_handle_start_climate
    await vehicle.start_climate(set_temp, duration, defrost, climate, heating)
  File "/config/custom_components/kia_uvo/Vehicle.py", line 138, in start_climate
    if(self.engine_type == VEHICLE_ENGINE_TYPE.EV and self.region == REGION_CANADA):
AttributeError: 'Vehicle' object has no attribute 'region'
2021-11-13 14:21:37 ERROR (MainThread) [homeassistant.components.websocket_api.http.connection] [2967215264] Error handling message: Unknown error
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/components/websocket_api/decorators.py", line 26, in _handle_async_response
    await func(hass, connection, msg)
  File "/usr/src/homeassistant/homeassistant/components/websocket_api/commands.py", line 523, in handle_execute_script
    await script_obj.async_run(msg.get("variables"), context=context)
  File "/usr/src/homeassistant/homeassistant/helpers/script.py", line 1243, in async_run
    await asyncio.shield(run.async_run())
  File "/usr/src/homeassistant/homeassistant/helpers/script.py", line 353, in async_run
    await self._async_step(log_exceptions=False)
  File "/usr/src/homeassistant/homeassistant/helpers/script.py", line 371, in _async_step
    await getattr(self, handler)()
  File "/usr/src/homeassistant/homeassistant/helpers/script.py", line 571, in _async_call_service_step
    await service_task
  File "/usr/src/homeassistant/homeassistant/core.py", line 1495, in async_call
    task.result()
  File "/usr/src/homeassistant/homeassistant/core.py", line 1530, in _execute_service
    await handler.job.target(service_call)
  File "/config/custom_components/kia_uvo/__init__.py", line 91, in async_handle_start_climate
    await vehicle.start_climate(set_temp, duration, defrost, climate, heating)
  File "/config/custom_components/kia_uvo/Vehicle.py", line 138, in start_climate
    if(self.engine_type == VEHICLE_ENGINE_TYPE.EV and self.region == REGION_CANADA):
AttributeError: 'Vehicle' object has no attribute 'region'
cdnninja commented 2 years ago

What region and brand?

On Nov 13, 2021, at 6:24 AM, JamesT42 @.***> wrote:

 Hi!

climate service is broken in latest version

2021-11-13 14:21:37 ERROR (MainThread) [homeassistant.helpers.script.websocket_api_script] websocket_api script: Error executing script. Unexpected error for call_service at pos 1: 'Vehicle' object has no attribute 'region' Traceback (most recent call last): File "/usr/src/homeassistant/homeassistant/helpers/script.py", line 371, in _async_step await getattr(self, handler)() File "/usr/src/homeassistant/homeassistant/helpers/script.py", line 571, in _async_call_service_step await service_task File "/usr/src/homeassistant/homeassistant/core.py", line 1495, in async_call task.result() File "/usr/src/homeassistant/homeassistant/core.py", line 1530, in _execute_service await handler.job.target(service_call) File "/config/custom_components/kia_uvo/init.py", line 91, in async_handle_start_climate await vehicle.start_climate(set_temp, duration, defrost, climate, heating) File "/config/custom_components/kia_uvo/Vehicle.py", line 138, in start_climate if(self.engine_type == VEHICLE_ENGINE_TYPE.EV and self.region == REGION_CANADA): AttributeError: 'Vehicle' object has no attribute 'region' 2021-11-13 14:21:37 ERROR (MainThread) [homeassistant.components.websocket_api.http.connection] [2967215264] Error handling message: Unknown error Traceback (most recent call last): File "/usr/src/homeassistant/homeassistant/components/websocket_api/decorators.py", line 26, in _handle_async_response await func(hass, connection, msg) File "/usr/src/homeassistant/homeassistant/components/websocket_api/commands.py", line 523, in handle_execute_script await script_obj.async_run(msg.get("variables"), context=context) File "/usr/src/homeassistant/homeassistant/helpers/script.py", line 1243, in async_run await asyncio.shield(run.async_run()) File "/usr/src/homeassistant/homeassistant/helpers/script.py", line 353, in async_run await self._async_step(log_exceptions=False) File "/usr/src/homeassistant/homeassistant/helpers/script.py", line 371, in _async_step await getattr(self, handler)() File "/usr/src/homeassistant/homeassistant/helpers/script.py", line 571, in _async_call_service_step await service_task File "/usr/src/homeassistant/homeassistant/core.py", line 1495, in async_call task.result() File "/usr/src/homeassistant/homeassistant/core.py", line 1530, in _execute_service await handler.job.target(service_call) File "/config/custom_components/kia_uvo/init.py", line 91, in async_handle_start_climate await vehicle.start_climate(set_temp, duration, defrost, climate, heating) File "/config/custom_components/kia_uvo/Vehicle.py", line 138, in start_climate if(self.engine_type == VEHICLE_ENGINE_TYPE.EV and self.region == REGION_CANADA): AttributeError: 'Vehicle' object has no attribute 'region'

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

JamesT42 commented 2 years ago

EU, Hyundai Ioniq 5

cdnninja commented 2 years ago

Could you try remove and readd the integration? If that solves it I think I know the issue.

JamesT42 commented 2 years ago

Well I removed it, and now I can't log in to readd. "Login failed into Kia Uvo / Hyundai Bluelink Servers. Please use official Kia Uvo app to logout and log back in and try again!" I've rechecked the username and password several times.

cdnninja commented 2 years ago

Well that is concerning. Could you enable debug logging outlined on GitHub and post the error? Wondering if it’s the new login issue we have seen.

On Nov 13, 2021, at 8:40 AM, JamesT42 @.***> wrote:

 Well I removed it, and now I can't log in to readd. "Login failed into Kia Uvo / Hyundai Bluelink Servers. Please use official Kia Uvo app to logout and log back in and try again!" I've rechecked the username and password several times.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

cdnninja commented 2 years ago

@JamesT42 the login issue should be solved if it was the larger EU issue. Please re-open if this is still an issue.

JamesT42 commented 2 years ago

I was now able to delete the integration an add it again. But the error is still there.

2021-11-14 23:58:36 ERROR (MainThread) [homeassistant.helpers.script.websocket_api_script] websocket_api script: Error executing script. Unexpected error for call_service at pos 1: 'Vehicle' object has no attribute 'region'
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/script.py", line 371, in _async_step
    await getattr(self, handler)()
  File "/usr/src/homeassistant/homeassistant/helpers/script.py", line 571, in _async_call_service_step
    await service_task
  File "/usr/src/homeassistant/homeassistant/core.py", line 1495, in async_call
    task.result()
  File "/usr/src/homeassistant/homeassistant/core.py", line 1530, in _execute_service
    await handler.job.target(service_call)
  File "/config/custom_components/kia_uvo/__init__.py", line 91, in async_handle_start_climate
    await vehicle.start_climate(set_temp, duration, defrost, climate, heating)
  File "/config/custom_components/kia_uvo/Vehicle.py", line 150, in start_climate
    if self.engine_type == VEHICLE_ENGINE_TYPE.EV and self.region == REGION_CANADA:
AttributeError: 'Vehicle' object has no attribute 'region'
2021-11-14 23:58:36 ERROR (MainThread) [homeassistant.components.websocket_api.http.connection] [2969353544] Error handling message: Unknown error
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/components/websocket_api/decorators.py", line 26, in _handle_async_response
    await func(hass, connection, msg)
  File "/usr/src/homeassistant/homeassistant/components/websocket_api/commands.py", line 523, in handle_execute_script
    await script_obj.async_run(msg.get("variables"), context=context)
  File "/usr/src/homeassistant/homeassistant/helpers/script.py", line 1243, in async_run
    await asyncio.shield(run.async_run())
  File "/usr/src/homeassistant/homeassistant/helpers/script.py", line 353, in async_run
    await self._async_step(log_exceptions=False)
  File "/usr/src/homeassistant/homeassistant/helpers/script.py", line 371, in _async_step
    await getattr(self, handler)()
  File "/usr/src/homeassistant/homeassistant/helpers/script.py", line 571, in _async_call_service_step
    await service_task
  File "/usr/src/homeassistant/homeassistant/core.py", line 1495, in async_call
    task.result()
  File "/usr/src/homeassistant/homeassistant/core.py", line 1530, in _execute_service
    await handler.job.target(service_call)
  File "/config/custom_components/kia_uvo/__init__.py", line 91, in async_handle_start_climate
    await vehicle.start_climate(set_temp, duration, defrost, climate, heating)
  File "/config/custom_components/kia_uvo/Vehicle.py", line 150, in start_climate
    if self.engine_type == VEHICLE_ENGINE_TYPE.EV and self.region == REGION_CANADA:
AttributeError: 'Vehicle' object has no attribute 'region'

Also I see no way to reopen this issue...

fuatakgun commented 2 years ago

@cdnninja this seems to be a problem

cdnninja commented 2 years ago

Mistake on my side. I put in a fix that should solve this. Are you able to retest?

JamesT42 commented 2 years ago

Yes thank you it is fixed now.