Closed Kevr0n228 closed 2 years ago
What region are you in? Assuming not Canada you should have it running start_climate and never start_climate_ev. Currently only Canada needs a separate EV command. This is probably something we could clean up to make more clear.
You are correct in that neither of those values are a string but rather a number.
Before commenting out what error or issue were you seeing?
I am in Canada - sorry for not including that in the first post.
I have a 2021 Kona Electric. Climate is not starting with the climate_start service. all other sensors/services (like door unlock/lock) seem to work fine. I'm also in Canada.
I'm not confortable editing the python file directly. So I guess I'll wait for the next update that may include a fix.
@Kevr0n228 are you able to test out #216?
@cdnninja - tested #216, start_climate_ev and stop_climate worked as expected. Thanks for the fix!
@zadigre if you reload in HACS from "master" it will work now. Other option is a new release number will come out Wednesday.
@cdnninja confirmed working fine on "master".
thank you!
@cdnninja although it's working fine to start climate, when I use the "stop climate" service, it doesn't stop the defrost (yes confirmed in my car... front defrost still enabled and running)... but Air Conditionner, Steering Wheel Heater and Back Window Heater are stopped properly.
is this a bug in the integration or it's just the way it is for my car/Bluelink?
to make the defroster stop, I had to run start climate with "Defroster: False" and then run stop climate service.
@zadigre could you test with the app to see if you get the same thing? The command we currently send doesn't specify what to turn off just a general off command. Maybe we can specify though.
@cdnninja I saw the other thread that said 1 out of 10 times, front defrost does not disable itself in the app when stopping climate. And yes I see the same behaviour in the app (I never experienced this before because I never had to turn off climate.
that said, starting climate is a little bit buggy with my car/Bluelink... I have to enable defrost to get it to start without any error in the app. Others on Reddit have said they experienced the exact same thing. So I guess the stop problem might be related to this same issue.
@zadigre good to know this isn't our implementation.
I am going to close this again as it looks like the OP's issue is solved.
I just updated to v1.26 after working with @cdnninja to get climate working in Hyundai EVs and it working after taking the update. I did some poking around in the code and was able to determine that it was calling
start_climate
instead ofstart_climate_ev
as a result of this check on line 195 of Vehicle.py not evaluating to true:if self.engine_type == VEHICLE_ENGINE_TYPE.EV and self.region == REGION_CANADA:
it seems that
self.region
does not equalREGION_CANADA
("Canada"), and from what I could tell it isn't even a string. Printing it out with_LOGGER.debug
errored out saying it was an int, and when cast to a string it evaluated to '2' - possibly related toREGION_CANADA
's position in theREGIONS
dictionary? I solved it for myself by commenting out part of the condition that checks the region, but I couldn't come up with a proper fix for everyone else.