search

Hyundai-Kia-Connect / kia_uvo

A Home Assistant HACS integration that supports Kia Connect(Uvo) and Hyundai Bluelink. The integration supports the EU, Canada and the USA.
MIT License
413 stars 85 forks source link

fix(EU): stamp generation #689

Closed kalaws closed 1 year ago

kalaws commented 1 year ago

Like so?

erikgeurts commented 1 year ago

For future reference, this is a fix for #686 .

mvroosmalen1970 commented 1 year ago

For future reference, this is a fix for #686 .

Confirmed solved! Thanks

artursulkowski commented 1 year ago

I can also confirm that it's working with new version of hyundai_kia_connect_api. My setup: Hyundai Bluelink, region EU How about new official release so it becomes available over HACS?

fuatakgun commented 1 year ago

Done

erikgeurts commented 1 year ago

I see the latest release got bumped to 2.0.17 just now, but that doesn't include this particular change. Is there a 2.0.18 pending?

cdnninja commented 1 year ago

I see the latest release got bumped to 2.0.17 just now, but that doesn't include this particular change. Is there a 2.0.18 pending?

If you want to see the key change go look at our underlying api and what changed in it. This bumps to use that new version.

erikgeurts commented 1 year ago

What I mean is there is still no formal release 2.0.18 or otherwise at https://github.com/Hyundai-Kia-Connect/kia_uvo/releases that includes this. As such, unsuspecting Home Assistant users that have this integration installed via HACS won't know there's a fix for the problem they must be facing by now.

cdnninja commented 1 year ago

What I mean is there is still no formal release 2.0.18 or otherwise at https://github.com/Hyundai-Kia-Connect/kia_uvo/releases that includes this. As such, unsuspecting Home Assistant users that have this integration installed via HACS won't know there's a fix for the problem they must be facing by now.

2.0.17. Looks like the commit didn't get caught by our GitHub action for release notes. It is included though.

erikgeurts commented 1 year ago

Ah, yes, I see it now, after comparing 2.0.16 with 2.0.17: https://github.com/Hyundai-Kia-Connect/kia_uvo/compare/v2.10.6...v2.10.7