Hywela / Tab-Postion-Cuztomizer-Modified

Extension for chrome - web browser: Manage tabs
MIT License
29 stars 7 forks source link

Wrong tab focus on opening new tab (after closing certain tab) (On 1.3.8) #29

Closed kissglay closed 2 years ago

kissglay commented 2 years ago

Describe the bug I decide to open a new issue, because it's similar to issue #28 but not exactly same. It doesn't snap back to the very 1st tab of current window, and it's now happening when opening a new tab from a tab whose parent tab (sort of) was just closed.

To Reproduce Steps to reproduce the behavior:

(On 1.3.8 of the extension) Of course, it's not the only way to trigger the issue but it's relatively concise to explain and reproduce.

The only setting modified is "New Tab -> Not Activated(Background)". As for the sequence of operations performed, plz refer to the attachment, and is described as follows:

  1. From 2nd tab, Alt+Enter to open 3rd tab.
  2. Switch to 3rd tab and middle mouse clicks to open whatever other tabs.
  3. Close 3rd tab and focus is now on 4th tab (now 3rd tab due to the one just closed).
  4. Ctrl+Shift+T (reopen last closed tab) Now the focus is on 2nd tab, which is the opener of the recovered tab (3rd tab).

Expected behavior Tab focus shouldn't have changed.

Screenshots 2021-10-12_01 37 16 688_chrome_Tab_Position_customizer_modified_-_Options_-_Googl 2021-10-12_01 46 44 047

Desktop (please complete the following information):

kissglay commented 2 years ago

Another sequence of operations to reproduce it:

  1. From the 2nd tab, Alt+Enter to open the 3rd tab.
  2. Switch to the 3rd tab and middle mouse clicks to open whatever other tabs.
  3. Close the 3rd tab and focus is now on the 4th tab (now the 3rd tab due to the one just closed).
  4. Try middle-clicking a link and open it in the background, but the focus snaps back to the 2nd tab.

2021-10-13_12 09 43 397

Hywela commented 2 years ago

Hi, Thank for reporting this issue you are experiencing. Going to look into it during next week.

kissglay commented 2 years ago

Came across another case: (In this case, the one closed is not some sort of parent tab) 2021-10-18_21 46 12 092

kissglay commented 2 years ago

Any progress on resolving this issue?

Hywela commented 2 years ago

Been very busy lately so it took some time. But yes the new version I'm testing localy seems to be working fine.

Unfortunately there are alot of functions and combinations and before i push it to the chrome store I will keep it for testing a week or more.

I estimate around friday at the earliest.

kissglay commented 2 years ago

Take your time and no rush.