Hzfinfdu / Diffusion-BERT

ACL'2023: DiffusionBERT: Improving Generative Masked Language Models with Diffusion Models
Apache License 2.0
286 stars 24 forks source link

unfinished codebase? #18

Open tomtom1103 opened 1 year ago

tomtom1103 commented 1 year ago

Hello, first, thank you for your work. I find it fascinating! I was wondering if the codebase isn't yet complete, since the predict.py and predict_downstream_conditionals.py still have missing imports, etc.

I was hoping to see how the model actually functions after I've trained it after one epoch. Any plans on updating soon?

Hzfinfdu commented 1 year ago

Hi, Do you mean modeling_elasticbert.py? I received an email reporting this but forgot to update :(

Traceback (most recent call last): File "predict.py", line 5, in from models.modeling_elasticbert import ElasticBertForPreTraining ModuleNotFoundError: No module named 'models.modeling_elasticbert'

If the missing import is some huggingface modeling files, just comment them out and run predict.py. This is because we evaluated DiffusionBERT on some other PLMs but did not report those results.

This issue will be solved soon :)

Hzfinfdu commented 1 year ago

Hi, I deleted the missing import in the last commit https://github.com/Hzfinfdu/Diffusion-BERT/commit/404d222f1535fa971908c2099b227d9b94d55fdc. Did you clone before that? Pulling again may help.