search

I-A-C / plugin.video.exodusredux

GNU General Public License v3.0
20 stars 13 forks source link

Fix Trakt Authorization dialog on Trakt.tv #15

Closed drinfernoo closed 5 years ago

drinfernoo commented 5 years ago

This isn't something in THIS add-on, but the fact that Exodus Redux comes up on Trakt.tv as "Test" with no icon, whenever we try to authorize it.

I-A-C commented 5 years ago

That does look a little sketchy.. I'll have to look into that.

drinfernoo commented 5 years ago

@I-A-C It's very easym You can edit it directly on Trakt.tv, and it updates immediately.

I-A-C commented 5 years ago

I didn't have authority over the current Trakt API key, so I created a new trakt API key with icon and named ExodusRedux. If I upload a new Trakt API key, will that adversely affect the current installed user base or will it be as easy as reauthorizing?

doko-desuka commented 5 years ago

If the user has a cached token from a previous use, it'll be for the old API key.
When the user tries to go into their Trakt manager, it'll try to use this cached token but with the new key. It'll keep failing in an obscure way, because the code sees that there's a cached token and assumes that it should definitely work with the key and will keep trying to do that.
It doesn't have a failsafe at the moment.

drinfernoo commented 5 years ago

In other words, users will have to reauthorize.

doko-desuka commented 5 years ago

Did anyone test it with the new API key? What are you getting?

drinfernoo commented 5 years ago

Is there a new API key? I only update whenever it hits the repo.

doko-desuka commented 5 years ago

I think so, there's a commit from Nov 15 on script.module.exodusredux:
https://github.com/I-A-C/script.module.exodusredux/commit/288de8330f3954b279e6e745848dede1275c7681

drinfernoo commented 5 years ago

The changes went live in the repo today.