search

I-A-C / plugin.video.exodusredux

GNU General Public License v3.0
20 stars 13 forks source link

Lambda Default after reboot/closeout #22

Closed ghost closed 5 years ago

ghost commented 5 years ago

Add Documentary Section Addon.xml - Youtube installs by default Default.py - add Docuheaven navigator Service.py - uncomment repo, may help in debugging

SerpentDrago commented 5 years ago

Thank you for Contributing changes/fix's

host505 commented 5 years ago

@13Clowns so if I understood correctly, your proposed solution to scraper choice resetting (never had this btw) is to disable the ability to choose internal scrapers?

Side note: as I understand it some commits here are related to your other pr (https://github.com/I-A-C/script.module.exodusredux/pull/5). To avoid this, and create 2 separate prs with different commits, you should create different branches in your fork, each one with the proposed corresponding changes.

ghost commented 5 years ago

@host505 We haven't had this issue either, although we did notice that when you select default sources the source folder is empty with the exception of trailers.py. This also causes a "NO STREAMS" message. So why have it as an option if there are no scrapers?

If we missed something let us know.

We will change PR going forward.

host505 commented 5 years ago

As I understand it, exodus redux was supposed to be a neutral add-on, that only provided trailers by default. User had to explicitly enable lambdascrapers (on the first iteration of the plugin lambdascrapers where not even installed by default, dependency was optional). This plugin was supposed to be something like a template. That changed at some point (I guess because of users whining/unable to change some settings), and ls became a mandatory dependency, and also the default scraper selection.

But if you propose to ditch the internal scrapers completely (I don't agree but it's not my call, not my plugin), there are more things to be done than settings mods: sources.py adjustments etc.

ghost commented 5 years ago

We see what your saying and we're under the impression that this was a dependency that works great inside the templates. It does and with regular updates. We did not know it was originally a template. We can see how things got confusing and changed around. Like you not our add-on if I-A-C wants to keep as is disregard any PR we have sent.

host505 commented 5 years ago

Of course, I just try to explain things as I have conceived them. I might be wrong. I hope you didn't get my comments the wrong way.

I-A-C commented 5 years ago

@13clowns, thank you for contribution.

@host505 observation that exodusredux is supposed to be a sort of template is spot on. I started this project because I was amazed that after all these years, the general framework/template that lambda put out still works with some minor tweaking. Everybody wants to reinvent the wheel, I just wanted to keep the wheel rolling and followed through on suggestions that separating the sources module from the addon itself would be a good way to do that. 2 months later, that seems to be bearing out.

I'm drawn to coding side of development and care very little about looks and lists. On the other hand, I know that others spend quite a bit of time creating new content through the use of custom menus and curated list. Since I'm not a content creator, I'm hesitant to just grab someone content, unless it's open-source.

The use of custom art, menus and lists is what differentiates one from another and differentiation should make for a better user experience. I encourage anyone who wants to try their hand at creating their own addon to use ExodusRedux as a template to start from. Fork/copy/paste whatever. The more addons that implement Lambdascrapers the better.

jewbmx commented 5 years ago

Who tested the LS on a jen template? lol