I-A-C / plugin.video.exodusredux

GNU General Public License v3.0
20 stars 13 forks source link

Bungled titles on widget items #24

Closed drinfernoo closed 5 years ago

drinfernoo commented 5 years ago

Not sure exactly what is going on here, but it appears that on the latest version, titles on widget items are formatted in some weird way.

The first two images in this album are from widgets populated by Exodus Redux, while the second two are from another add-on.

https://imgur.com/a/1YhfKeB

SerpentDrago commented 5 years ago

Widgets pointed to a Redux > Trakt List correct ? that info could be helpfull

host505 commented 5 years ago

What skin is this? I checked Confluence and can't repoduce (Estuary doesn't have widget titles). Are you sure this occurred only since the last update? I'm suspecting this, can you try to comment-out that line?

drinfernoo commented 5 years ago

@SerpentDrago Indeed, from a Trakt list. My bad.

drinfernoo commented 5 years ago

@host505 I'm sure it's just since the latest build, as it isn't doing this on my Shield, on a previous build. The skin is Aura, in both cases.

Tikipeter commented 5 years ago

host505 is most likely right about it being the cause of the incorrect labeling.

Even if it's not the cause, the suspected line should be:

meta.update({'tvshowtitle': i['originaltitle']})

This is my fault when trying to fix Extended Info for TV Shows. I didn't take anywhere near enough notice of the variable I used.

Sorry. :( :( :(

drinfernoo commented 5 years ago

@Tikipeter Probably should be just 'title' or 'name', rather than 'originaltitle', then?

host505 commented 5 years ago

I couldn't reproduce with aura skin. Does this occur with Kodi 17 or 18? @drinfernoo can you replace line 1073 of tvshows.py with the one suggested by Tikipeter?

Tikipeter commented 5 years ago

@drinfernoo 'title' and 'originaltitle' are always the same, so it could be either.

There is no 'name' key though, so don't change it to that.

jewbmx commented 5 years ago

Omg so 2mins of looking at those pics and i finally spot the titles and figure out i dont need to open them from the page lol then i toss down my phone for a minute to eat a burger and start tryin to swipe thru like its a damn movie site or netflix lmao. Think imma goto bed or stop smokin.

Also like to note that originaltitle should be the best choice in the long run but thats debatable due to some crappy labeling for some stuff you find.