search

I-Connect / NukiBleEsp32

MIT License
37 stars 21 forks source link

Build pull requests #55

Closed dotdoom closed 5 months ago

dotdoom commented 5 months ago

This should highlight compile issues in PRs.

dotdoom commented 5 months ago

Tested that this catches compile error introduced in #52

https://github.com/dotdoom/NukiBleEsp32/actions/runs/9226801174/job/25387372051?pr=2

dotdoom commented 5 months ago

de-vri-es/setup-git-credentials@v2 has been removed since I believe it is only relevant when working with private repositories.

Since this is a public repository (now), it should not be necessary anymore - but please yell at me if you know otherwise.

iranl commented 5 months ago

@Bascy: Can we get this merged so the other PR's can also be converted from draft and merged?