Closed jurplel closed 5 years ago
Konsole and yakuake are check boxes because there is still an option to run pacman -Syu in the background if neither are selected
Maybe there should be a "Run in the background" radio button?
That's exactly why i have it as checkboxes
It's too cluttered plus background only works if aur support is disabled
Background won't work for aur
Well, suit yourself. Is there anything you want me to change in this pull request?
I've been at work and haven't pulled it to check it out
I'll check it tonight
Sorry for the delay
No problem at all!
Checked it out
Switching to light or dark doesn't change anything for me.
Also when I restart my plasmashell for light and dark and open settings again it's still on the "default" radio button
Custom ones stays though
Going from custom to default doesn't set it back again either
it appears you never uploaded the new icons to this pull request
Wow, I don't know how that happened. They should be in now
The only thing is if you don't approve the authentication request, the radio button will stay without the actual icon state changing
I did approve it Restarted plasma shell Opened settings Was still selected as default
https://streamable.com/rx6mp working here (assuming you updated to the commit i just pushed with the images actually included)
I'll check it again tomorrow
Need to pull an early shift at work
Hey just wanted to say thanks for cleaning up the mess of the config qml file. been meaning to get around to it
No problem, glad I helped
Adds four options for the icon: default (as it is now), light (matches with breeze dark), dark (matches with breeze light), and the custom option as it is now. The configuration dialog is also rearranged a bit to make it fit in better. It might be good in the future to make the older options fit more with the newer ones, such as making the konsole and yakuake options radio buttons instead of individually labeled checkboxes