I-Dream-in-Code / kde-arch-update-plasmoid

30 stars 9 forks source link

SVG icons and bug fixes #39

Closed jurplel closed 5 years ago

jurplel commented 5 years ago
I-Dream-in-Code commented 5 years ago

custom icon is broken with your update

I-Dream-in-Code commented 5 years ago

your case 3 in systemcalls.cpp copies default.svg versus filename

jurplel commented 5 years ago

fixed

I-Dream-in-Code commented 5 years ago

still broken

won't even show icon now kde-512

I-Dream-in-Code commented 5 years ago

when trying to open chosen.svg from /usr/share/plasma/plasmoids/org.kde.archUpdate/contents/images in inkscape image

jurplel commented 5 years ago

It's because it's expecting an SVG icon.

I-Dream-in-Code commented 5 years ago

yeah pretty sure implicit conversion to svg won't fly.

You can use convert maybe?

jurplel commented 5 years ago

I don't wanna add any extra dependencies - This should work by making Qt resolve the file extension implicitly

I-Dream-in-Code commented 5 years ago

great work thanks for the contribution