I-Dream-in-Code / kde-arch-update-plasmoid

30 stars 9 forks source link

Since last update plasmoid shows previous update status #6

Closed ghost closed 6 years ago

ghost commented 6 years ago

First update checking works ok. Second update show status from first update. Third update shows status from second update and so on...

I-Dream-in-Code commented 6 years ago

When you say status is it the actual old checkupdates return value?

Or an actual status message?

I-Dream-in-Code commented 6 years ago

Also how are you running check updates?

Do you repeatedly click check updates?

Do you repeatedly click after an upgrade?

Hoping for more information.

I added a blocking queue to the slot but I need more background from you

I-Dream-in-Code commented 6 years ago

pretty sure the blocking queue fixed it as it fixed this bug I had with a different branch

I-Dream-in-Code commented 6 years ago

updated the master branch, let me know if that fixed it

also updated the AUR package

ghost commented 6 years ago

I set update timer to 60min and plasmoid always showed me packages which I already updated one hour ago instead of current updates. I had to click to check updates again to see current updates. I upgraded plasmoid and will report if this is fixed.

ghost commented 6 years ago

This issue seems to be fixed however plasma ui starts freezing again (even worse than before) during update process. I hope it can be solved without issues like this in the future.

I-Dream-in-Code commented 6 years ago

Yeah that's the nasty thing about blocking queue

I'm gonna rewrite it with an actual mutex true multithreading

I-Dream-in-Code commented 6 years ago

@fancytenseletters QML makes asynchronous calls but I added a half semaphore and it shouldn't freeze and also updates correctly

I have to wait for upgrades to test further

I-Dream-in-Code commented 6 years ago

@fancytenseletters I fixed it and do apologize for that bad implementation before.

the master branch and AUR package are both updated

ghost commented 6 years ago

@I-Dream-in-Code Hmm this time plasmoid doesn't show upgradable packages in its window. Only number of updates is shown in tray. Choosing "Update system" works ok (I'm using Konsole output).

I-Dream-in-Code commented 6 years ago

@fancytenseletters somehow the"text" : packagelist[i] was missing text: and just packageList[i]

Updated master and AUR

ghost commented 6 years ago

Thanks!