I-GUIDE / data-catalog-archive

The IGUIDE data catalog
3 stars 3 forks source link

Remove Date type from core schema #48

Closed Castronova closed 1 year ago

Castronova commented 1 year ago

Discussion from Slack:

Pabitra

It seems from our schema specification (https://github.com/I-GUIDE/data-catalog/blob/main/schema/core.md#dates), that we should be supporting both date and datetime for dateCreated, dateModified, and datePublished. However, the current implementation of pydantic model supports only datetime. I remember in the initial implementation we had both date and datetime. may know why we removed the support for date. Should I add date back?

Jeff

do we need both here? A date can be stored as a datetime. I suggest we support one. And since datetime is inclusive of both, i suggest we keep datetime.

Tony

I agree with Jeff that we only need to support datetime. Our example in core.md was more of a demonstration of acceptable ways to represent dates within the schema. We shouldn’t need to support both. datetime is inclusive of date.

Action

igarousi commented 1 year ago

Done. See commit #ba03d33.