I-TECH-UW / OpenELIS-Global-2

OpenELIS 2.X is a rewrite of the original OpenELIS global with updated components and technology
http://openelis-global.org/
Mozilla Public License 2.0
71 stars 188 forks source link

Duplicate National IDs are persisted even after setting the 'duplicate national ID' property false #788

Closed common-cold closed 5 months ago

common-cold commented 6 months ago

Issue Description:

The Patient Configuration Menu has fields such as

Even after toggling their values to false, new patients can be persisted with duplicate national IDs and subject Number. Currently there is no Validator present in the backend during the process of saving a new patient.

  1. Patient Configuration Menu can be accessed by :

Admin -> Legacy Admin -> Patient Entry Configuration

Here the properties can be toggled to true or false.

Screenshots of the issue:

Duplicate National ID Property is set to false:

Screenshot 2024-03-11 000026

Patients with duplicate national IDs are being persisted:

Screenshot 2024-03-11 000217

common-cold commented 6 months ago

@mozzy11 can you assign this issue to me.

codewithunknown commented 6 months ago

@mozzy11 @common-cold

just a heads up maybe, what I would say is there can be mutiple patients with same national ID

@mozzy11 I would suggest by default we can keep allowing mutiple patients with same national ID because say I am from uganda then there would be no point if only one patient from uganda can use our application

just reconsidering the edge cases

common-cold commented 6 months ago

@codewithunknown from what I could understand the national ID in the codebase refers to the unique identification no. given by the government to its citizen. In India we have Aadhaar Card as our National ID. I don't think the code base refers to the Country Code as national Id. Correct me if I'm wrong.

mozzy11 commented 6 months ago

@common-cold any progress or blocker here ??

mozzy11 commented 6 months ago

hello @common-cold any progress ??

common-cold commented 6 months ago

@mozzy11 yes i have done changes in the code-base I'll generate a PR soon.