search

I2PC / scipion

Scipion is an image processing framework to obtain 3D models of macromolecular complexes using Electron Microscopy (3DEM)
http://scipion.i2pc.es
Other
76 stars 47 forks source link

replace wget cmd with curl #1950

Closed yaizar closed 5 years ago

yaizar commented 5 years ago

Change the download command to avoid the zero size files when the download fails

pconesa commented 5 years ago

I've been testing this, the idea was to be more robust to downloads errors. Turns out that what we already had is also robust..I need to do more test but this might not improve anything? Or I'm missing the scenario where this would improve it.

azazellochg commented 5 years ago

I had few times when the file didn't exist on server ending up with a few kB tgz file (with 404 header I guess) and then it tried to continue the installation..

pconesa commented 5 years ago

I've tried that but never manage to end up with "bytes" in the file.....In that case, I think even curl will fail...unless, this cannot happen with curl.

delarosatrevin commented 5 years ago

If there is no clear advantage, I will keep it as it is. Indeed, we are downloading to a temp file and then moving. Maybe we could concatenate both commands (wget .. || mv ..) so in case of error the temporary wrong-size file does not end as the expected file.

pconesa commented 5 years ago

I'm leaving this out.